{"type":"rich","version":"1.0","author_name":"npub12vlytlltjj7g3s227u9jtx2g8qtsu7gscynnn99k808ydr4vygcqvdqa4q","author_url":"https://nostr.ae/npub12vlytlltjj7g3s227u9jtx2g8qtsu7gscynnn99k808ydr4vygcqvdqa4q","provider_name":"njump","provider_url":"https://nostr.ae","html":"📅 Original date posted:2015-01-21\n📝 Original message:-----BEGIN PGP SIGNED MESSAGE-----\nHash: SHA512\n\nOn 2015/1/20 19:35, Pieter Wuille wrote:\u003e Hello everyone,\n\u003e Comments/criticisms are very welcome, but I'd prefer keeping the \n\u003e discussion here on the mailinglist (which is more accessible than\n\u003e on the gist).\n\nNice paper, Pieter. I do have a bit of feedback.\n\n1)The first sentence of \"Deployment\" has a typo. \"We reuse the\ndouble-threshold switchover mechanism from BIP 34, with the same\n*thresholds*, [....]\"\n\n2)I think the handling of the sighash byte in the comments of\nIsDERSignature() could use a little tweaking. If you look at\nCheckSignatureEncoding() in the actual code (src/script/interpreter.cpp\nin master), it's clear that the sighash byte is included as part of the\nsignature struct, even though it's not part of the actual DER encoding\nbeing checked by IsDERSignature(). This is fine. I just think that the\ncode comments in the paper ought to make this point clearer, either in\nthe sighash description, or as a comment when checking the sig size\n(i.e., size-3 is valid because sighash is included), or both.\n\n3)The paper says a sig with size=0 is correctly coded but is neither\nvalid nor DER. Perhaps this code should be elsewhere in the Bitcoin\ncode? It seems to me that letting a sig pass in IsDERSignature() when\nit's not actually DER-encoded is incorrect.\n\nThanks.\n\n- ---\nDouglas Roark\nSenior Developer\nArmory Technologies, Inc.\ndoug at bitcoinarmory.com\nPGP key ID: 92ADC0D7\n-----BEGIN PGP SIGNATURE-----\nVersion: GnuPG/MacGPG2 v2.0.22 (Darwin)\nComment: GPGTools - https://gpgtools.org\n\niQIcBAEBCgAGBQJUv/4vAAoJEGybVGGSrcDXMxkP/1N2lLAloCKdRUpMBLPEZ5jh\nbJ4reCeqrMy6JetsKSGfGKdAe7kGkeRl6s8dlHYnpUmnODXU9BCku3zHi3+qm8IC\nGZlwSdSSgmRneP7btPula0CG31o7X2UJiDW/2IOZl6ul8b7LB2L56O+Ew+PNm+at\ntCfRcpKtq9LYCnRYR0azd4c5YY9/o7zlkpGi8CututzuEa4Rcm92U1extoo2tC/j\nnzUfbfcQVL0a7JaRU4VYNceYrcG/xSpKPjsEU/F+5IwnUxL/kebz0EDt1kzm+fOE\nEMUMXyYgoyW5VDFNjxu00PnJUfVNCOXN/N/h9eCdskCL3AtH6xg1kzam5OGvpEZS\nQDMNSmQl4Zpx5WiATylNkhhzb/8GowamkSFg4SUjBsjpwOTMTIF0Qhnt+DdzwpI2\netxCGds154nL4p/bkulseczwxOZWin9oZxJnCxp40oFl8fva0BwHVx45uMyI61Ko\nqRJ9Ol0CDoId3h1EMTt4uyoNxrOzgrj8/+V4BBytOAMMmsfD0VgY68xzdywJxYnC\njgU99huhwtJpn9QT6JAbgPAaboomu6hDCohV+J+DCCkIiYFk1jxp+FQ4xZDzcKeo\ngMYpmFefPAxnHvDXf1v1A+Xw8plN6/NREaIpprh7Ep+q/8vYAiwwHfKjubdMkB3D\nWnTR5YbqyGxc/Pvh9Ncq\n=C/wj\n-----END PGP SIGNATURE-----"}