{"type":"rich","version":"1.0","author_name":"npub17rld56k4365lfphyd8u8kwuejey5xcazdxptserx03wc4jc9g24stx9l2h","author_url":"https://nostr.ae/npub17rld56k4365lfphyd8u8kwuejey5xcazdxptserx03wc4jc9g24stx9l2h","provider_name":"njump","provider_url":"https://nostr.ae","html":"📅 Original date posted:2021-02-22\n📝 Original message:On Fri, Feb 19, 2021 at 12:48:00PM -0500, Matt Corallo via bitcoin-dev wrote:\n\u003e It was pointed out to me that this discussion is largely moot as the\n\u003e software complexity for Bitcoin Core to ship an option like this is likely\n\u003e not practical/what people would wish to see.\n\u003e Bitcoin Core does not have infrastructure to handle switching consensus\n\u003e rules with the same datadir - after running with uasf=true for some time,\n\u003e valid blocks will be marked as invalid, \n\nI don't think this is true? With the current proposed bip8 code,\nlockinontimeout=true will cause headers to be marked as invalid, and\nwon't process the block further. If a node running lockinontimeout=true\naccepts the header, then it will apply the same consensus rules as a\nlockinontimeout=false node.\n\nI don't think an invalid header will be added to the block index at all,\nso a node restart should always cleanly allow it to be reconsidered.\n\nThe test case in\n\nhttps://github.com/bitcoin/bitcoin/pull/19573/commits/bd8517135fc839c3332fea4d9c8373b94c8c9de8\n\ntests that a node that had rejected a chain due to lockinontimeout=true\nwill reorg to that chain after being restarted as a byproduct of the way\nit tests different cases (the nodes set a new startheight, but retain\ntheir lockinontimeout settings).\n\n\n(I think with the current bip8 code, if you switch from\nlockinontimeout=false to lockinontimeout=true and the tip of the current\nmost work chain is after the timeoutheight and did not lockin, then you\nwill continue following that chain until a taproot-invalid transaction\nis inclued, rather than immediately reorging to a shorter chain that\ncomplies with the lockinontimeout=true rules)\n\nCheers,\naj"}