rich1.0npub1w30zwgl8947760cd62fawy9hqmxnq24cga5c8s5j6j7m07w96dnqzjzhn2https://nostr.ae/npub1w30zwgl8947760cd62fawy9hqmxnq24cga5c8s5j6j7m07w96dnqzjzhn2njumphttps://nostr.ae📅 Original date posted:2022-06-16 📝 Original message:Hi cndm1, > If you see a "lack of basic options" and no one has opened a pull request for it, it may be for two reasons. The basic option to disable all RBF policies in a node's mempool if required was removed in [PR #16171][1]. No one has opened a pull request to revert this because most of the maintainers and a few reviewers agreed with this change. It wasn't required, PR had weak rationale, 2 NACKS and was reopened to merge because some reviewers/maintainers believe its a policy that cannot be maintained. One of the reviewers who NACKed it already maintains the config option to disable all RBF policies in Bitcoin Knots which is a derivative of Bitcoin Core. > However, repeatedly demanding others to do it for you is not helpful in open source software development. I am not demanding anyone to add a few lines of code and open a pull request. I am _reviewing_ a pull request in an open source project and sharing my feedback. Even Antoine and Luke agreed to add it if other reviewers have no issues or I can do it. This option in context with another being added for a new RBF policy was being discussed in [PR #25353][2] and my earlier emails in this thread. Other 'basic options' will be easier to accommodate with `-mempoolreplacement` used in [PR #25373] which is unlikely to be merged. [1]: https://github.com/bitcoin/bitcoin/pull/16171 [2]: https://github.com/bitcoin/bitcoin/pull/25353 [3]: https://github.com/bitcoin/bitcoin/pull/25373 /dev/fd0 Sent with Proton Mail secure email. ------- Original Message ------- On Thursday, June 16th, 2022 at 11:13 AM, linuxfoundation.cndm1--- via bitcoin-dev bitcoin-dev at lists.linuxfoundation.org wrote: > alicexbt wrote: > > > I do not have issues with multiple RBF policies being tried out and full-rbf being one of them. My disagreements are with rationale, lack of basic options in Bitcoin Core to employ/disable different RBF policies and a few arguments made in support for full-rbf. Whether it appears strawman or offtopic on github, there should be a place to share these disagreements. > > Bitcoin Core is open source software, where developers open pull > requests to try to get them merged after review. If you see a "lack of > basic options" and no one has opened a pull request for it, it may be > for two reasons. First, it could be that it just doesn't make sense, > so no one sees a point in implementing it. Secondly, it may be that it > isn't on anyone's list of priorities. In the second case, you are > welcome to share your preference once. Moreover, no one is holding you > back to implement it yourself and suggest a pull request. However, > repeatedly demanding others to do it for you is not helpful in open > source software development. > > cndm1 > > _______________________________________________ > bitcoin-dev mailing list > bitcoin-dev at lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev