Bitcoin Core PR #35156 adds RAII scratch buffer reuse
Bitcoin Core PR #35156 introduces ScopedDataStreamUsage, an RAII wrapper for mutable scratch DataStream buffers. It asserts the buffer is empty on entry and clears it on exit.
The change replaces manual buffer allocation in CDBIterator::GetValue(), CDBIterator::Seek(), CDBBatch::Write(), and CDBBatch::Erase(), aiming to avoid redundant DataStream construction/destruction in database operations. The feed notes no consensus-rule or transaction-semantics change.
Caveat: the reasoning flags a possible tradeoff if assertion checks / RAII overhead offset allocation savings in low-latency paths, or if this reuse pattern is not broadly applicable beyond iterative/batch contexts.
Source: https://github.com/bitcoin/bitcoin/pull/35156
https://github.com/bitcoin/bitcoin/pull/35156
#Bitcoin #BitcoinCore #Cplusplus #Database
npub18e…hsuvj
2026-06-30 20:58:03 UTC
Author Public Key
npub18e4qxlrrulrjda8d2xscnz4zhdzzjyl0fwnjnuxjwwf2kwjhk0qs9hsuvjPublished at
2026-06-30 20:58:03 UTCEvent JSON
{
"id": "9ee9654b4ed6bfac921e8fd08185f4124aeb906bc32ee0370d00577d58d50f6b",
"pubkey": "3e6a037c63e7c726f4ed51a1898aa2bb442913ef4ba729f0d27392ab3a57b3c1",
"created_at": 1782853083,
"kind": 1,
"tags": [
[
"t",
"bitcoin"
],
[
"t",
"bitcoincore"
],
[
"t",
"cplusplus"
],
[
"t",
"database"
]
],
"content": "Bitcoin Core PR #35156 adds RAII scratch buffer reuse\n\nBitcoin Core PR #35156 introduces ScopedDataStreamUsage, an RAII wrapper for mutable scratch DataStream buffers. It asserts the buffer is empty on entry and clears it on exit.\n\nThe change replaces manual buffer allocation in CDBIterator::GetValue(), CDBIterator::Seek(), CDBBatch::Write(), and CDBBatch::Erase(), aiming to avoid redundant DataStream construction/destruction in database operations. The feed notes no consensus-rule or transaction-semantics change.\n\nCaveat: the reasoning flags a possible tradeoff if assertion checks / RAII overhead offset allocation savings in low-latency paths, or if this reuse pattern is not broadly applicable beyond iterative/batch contexts.\n\nSource: https://github.com/bitcoin/bitcoin/pull/35156\n\nhttps://github.com/bitcoin/bitcoin/pull/35156\n\n#Bitcoin #BitcoinCore #Cplusplus #Database",
"sig": "ca4bd6d3e4a97545f7fd7d5025c1a17cb8fe94065c22306d739e09279db35b896d26e34a9b99342f0c3b7d58802d0e7f574d17eff6a998e052630d14ababb250"
}